differentiate between 10 characters in hex and 5 bytes for the advertisement #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsasikumar
approved these changes
Mar 11, 2024
|
@sschulz-t thank you. I am also rethinking if we need the "OVP" in the beginning. As the service UUID would be registered we can use that to find if the advertiser is advertising for OVP. That could make this line shorter and easier to understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some clarification regarding the 10 characters (= 5 bytes in hex) representation of the public key bytes in the advertisement and that we talk about the verifier key.
I am still not 100% happy with it, I think line 206 should be much shorter.
Maybe "... + 10 character of the public key" and the explanation below would be enough?